Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return custom exit code for non recoverable errors #817

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Oct 18, 2023

Description

For errors that require someone to look at what's going on, an exit code 166 is returned. Other errors will return a 1

Issue

closes #797

@status-im-auto
Copy link

status-im-auto commented Oct 18, 2023

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 06f718f #1 2023-10-18 19:25:21 ~1 min tests 📄log
✖️ 06f718f #1 2023-10-18 19:25:23 ~1 min tests 📄log
✔️ 06f718f #1 2023-10-18 19:25:39 ~1 min nix-flake 📄log
✔️ 06f718f #1 2023-10-18 19:26:07 ~2 min linux 📦deb
✔️ 06f718f #1 2023-10-18 19:27:30 ~3 min android 📦tgz
✔️ 06f718f #1 2023-10-18 19:27:45 ~4 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 596ccc0 #2 2023-10-18 19:30:06 ~1 min nix-flake 📄log
✔️ 596ccc0 #2 2023-10-18 19:30:27 ~2 min linux 📦deb
✔️ 596ccc0 #2 2023-10-18 19:30:34 ~2 min tests 📄log
✔️ 596ccc0 #2 2023-10-18 19:31:27 ~3 min android 📦tgz
✔️ 596ccc0 #2 2023-10-18 19:31:31 ~3 min ios 📦tgz
✔️ 596ccc0 #2 2023-10-18 19:31:38 ~3 min tests 📄log
✔️ 8b84786 #3 2023-10-19 15:54:05 ~1 min linux 📦deb
✔️ 8b84786 #3 2023-10-19 15:56:16 ~3 min tests 📄log
✔️ 8b84786 #3 2023-10-19 15:56:21 ~3 min ios 📦tgz
✔️ 8b84786 #3 2023-10-19 15:56:42 ~3 min android 📦tgz
✔️ 8b84786 #3 2023-10-19 15:56:59 ~3 min tests 📄log
✔️ 8b84786 #3 2023-10-19 15:57:12 ~4 min nix-flake 📄log

@richard-ramos richard-ramos removed the request for review from alaibe October 18, 2023 19:30
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

only one minor question is does the error get logged before exit happen?

@richard-ramos
Copy link
Member Author

LGTM

only one minor question is does the error get logged before exit happen?

oops. good point. I'll add that

@richard-ramos richard-ramos merged commit 4af7e7a into master Oct 19, 2023
2 checks passed
@richard-ramos richard-ramos deleted the custom-exit-code branch October 19, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: return different exits code on DB vacuum failure
5 participants