fix: deadlock in peer connector / manager interaction

[richard-ramos]

Description

Fixes the error seen on this build:
https://ci.status.im/blue/organizations/jenkins/go-waku%2Fprs%2Frace/detail/PR-828/4/pipeline/

Changes

• When creating a subscription to a discovery service, use the context that is provided to jump out of loop
• When AddDiscoveredPeer is invoked, use a goroutine to call PushToChan. This is because when calling the PeerConnector Stop() function, a write lock is acquired, and PushToChan tries to acquire a read lock immediately, and then Stop() gets stuck

[status-im-auto]

Jenkins Builds

Click to see older builds (6)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	bfd7d56	#1	2023-10-25 20:16:32	~1 min	nix-flake	📄log
✔️	bfd7d56	#1	2023-10-25 20:17:05	~2 min	linux	📦deb
✔️	bfd7d56	#1	2023-10-25 20:18:09	~3 min	tests	📄log
✔️	bfd7d56	#1	2023-10-25 20:18:29	~3 min	tests	📄log
✔️	bfd7d56	#1	2023-10-25 20:19:19	~4 min	android	📦tgz
✔️	bfd7d56	#1	2023-10-25 20:19:38	~5 min	ios	📦tgz

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	d760931	#2	2023-10-25 20:18:15	~1 min	linux	📦deb
✔️	d760931	#2	2023-10-25 20:18:28	~1 min	nix-flake	📄log
✔️	d760931	#2	2023-10-25 20:19:49	~4 min	ios	📦tgz
✖️	d760931	#2	2023-10-25 20:20:24	~2 min	tests	📄log
✔️	d760931	#2	2023-10-25 20:21:59	~3 min	tests	📄log
✔️	d760931	#2	2023-10-25 20:22:43	~3 min	android	📦tgz
✔️	d760931	#3	2023-10-25 22:30:24	~2 min	tests	📄log
✔️	a5683c2	#3	2023-10-26 01:16:20	~1 min	linux	📦deb
✔️	a5683c2	#3	2023-10-26 01:17:02	~1 min	tests	📄log
✔️	a5683c2	#3	2023-10-26 01:17:07	~1 min	nix-flake	📄log
✔️	a5683c2	#4	2023-10-26 01:18:30	~3 min	tests	📄log
✔️	a5683c2	#3	2023-10-26 01:18:51	~3 min	android	📦tgz
✔️	a5683c2	#3	2023-10-26 01:19:13	~4 min	ios	📦tgz

[chaitanyaprem]

Good find.
LGTM

[harsh-98]

lgtm.