You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDIT: Hmm... thinking more on this, I think we should change the protocols to WakuPubsubTopic wherever strings are used, but do it later, because if we do that now, we'd be automatically dropping support to named pubsub topics and this would mean that TheGraph wouldn't be able to use go-waku without changing their pubsub topic structure.
We should keep support for string pubsub topics for now
I'm wondering if we should we also replace the topic string by a WakuPubsubTopic in
* https://github.com/waku-org/go-waku/blob/8e549f7049037f4ea7778695aa78b2926e1bc2f8/waku/v2/protocol/relay/waku_relay.go#L227
* https://github.com/waku-org/go-waku/blob/8e549f7049037f4ea7778695aa78b2926e1bc2f8/waku/v2/protocol/lightpush/waku_lightpush_option.go#L43
* as well as wherever a pubsub topic is used in filter and store protocol?
EDIT: Hmm... thinking more on this, I think we should change the protocols to WakuPubsubTopic wherever strings are used, but do it later, because if we do that now, we'd be automatically dropping support to named pubsub topics and this would mean that TheGraph wouldn't be able to use go-waku without changing their pubsub topic structure. We should keep support for string pubsub topics for now
I remember Hanno mentioning that we are going to still have legacy API's so that existing users like TheGraph are not affected. Instead of modifying existing API's, we should be having new API's with deprecation note mentioned for existing API's that take pubsubTopic string.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
harsh-98
force-pushed
the
RemoveNamedTopic
branch
from
Description
Named pubsubTopic is being deprecated. Only default and shared pubsubTopic will be supported. In reference to #842
Changes
Tests