refactor: publish API for relay and lightpush #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
richard-ramos
force-pushed
the
refactor/publish
branch
from
c758801 to
0af3455
Compare
|
Opened also this issue due to noticing an incorrect behavior in the examples: #846 |
richard-ramos
force-pushed
the
refactor/publish
branch
from
0af3455 to
a70f61f
Compare
chaitanyaprem
approved these changes
Oct 27, 2023
richard-ramos
force-pushed
the
refactor/publish
branch
from
a70f61f to
f8d792f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the API for Lightpush and Relay were somewhat different and would really benefit from having a similar API.
Changes
PublishToTopicfrom Lightpush and Relay to use onlyPublishwith optionsexamples/noiseto thebuild-exampletargetProbably most of this work will go away once named shard support is removed, but whatever :D at least we wont have two separate Publish functions anymore