-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add messages logging subsystem #886
Conversation
Jenkins BuildsClick to see older builds (42)
|
babcefd
to
7fe4b24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Left a minor comment.
Also, is the logLevel configurable via a config option as well other than using env variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this as the comment is a minor one.
0efaf83
to
b469dae
Compare
@chaitanyaprem i just added an extra change that i forgot to push yesterday: b469dae . I think this line is redundant. |
98998e9
to
766f077
Compare
Adds a separate logging subsystem for relay/filter messages, to rely on https://github.com/ipfs/go-log#golog_log_level.
Also removes
logging.HexString
in favour oflogging.HexBytes
.