Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add messages logging subsystem #886

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

vitvly
Copy link
Contributor

@vitvly vitvly commented Nov 9, 2023

Adds a separate logging subsystem for relay/filter messages, to rely on https://github.com/ipfs/go-log#golog_log_level.

Also removes logging.HexString in favour of logging.HexBytes.

@vitvly vitvly self-assigned this Nov 9, 2023
@status-im-auto
Copy link

status-im-auto commented Nov 9, 2023

Jenkins Builds

Click to see older builds (42)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 72c76f4 #1 2023-11-09 11:51:26 ~2 min nix-flake 📄log
✔️ 72c76f4 #1 2023-11-09 11:51:40 ~2 min linux 📦deb
✔️ 72c76f4 #1 2023-11-09 11:53:14 ~3 min android 📦tgz
✔️ 72c76f4 #1 2023-11-09 11:53:52 ~4 min ios 📦tgz
✖️ 72c76f4 #1 2023-11-09 11:55:03 ~5 min tests 📄log
✔️ d34b63f #2 2023-11-09 11:55:26 ~3 min tests 📄log
✔️ d34b63f #2 2023-11-09 11:56:45 ~4 min ios 📦tgz
✔️ 0776315 #3 2023-11-09 11:55:59 ~2 min nix-flake 📄log
✔️ 0776315 #3 2023-11-09 11:56:12 ~2 min linux 📦deb
✔️ 0776315 #2 2023-11-09 11:56:34 ~3 min android 📦tgz
✔️ 0776315 #3 2023-11-09 11:58:02 ~4 min ios 📦tgz
✔️ 2bbfb7a #2 2023-11-09 11:57:23 ~2 min tests 📄log
✔️ 2bbfb7a #3 2023-11-09 11:58:00 ~2 min tests 📄log
✔️ 2bbfb7a #4 2023-11-09 11:58:20 ~2 min nix-flake 📄log
✔️ 2bbfb7a #4 2023-11-09 11:59:42 ~4 min ios 📦tgz
✔️ babcefd #5 2023-11-09 11:59:31 ~1 min linux 📦deb
✔️ babcefd #5 2023-11-09 12:01:47 ~4 min ios 📦tgz
✔️ babcefd #3 2023-11-09 12:01:47 ~4 min tests 📄log
✔️ 7fe4b24 #6 2023-11-09 12:00:43 ~1 min linux 📦deb
✔️ 7fe4b24 #6 2023-11-09 12:02:09 ~2 min nix-flake 📄log
✔️ 7fe4b24 #6 2023-11-09 12:03:12 ~4 min ios 📦tgz
✔️ 7fe4b24 #5 2023-11-09 12:03:32 ~3 min android 📦tgz
✔️ 7fe4b24 #5 2023-11-09 12:03:42 ~4 min tests 📄log
✔️ 7fe4b24 #4 2023-11-09 12:04:19 ~2 min tests 📄log
✔️ 996941c #7 2023-11-10 10:45:27 ~1 min linux 📦deb
✔️ 996941c #7 2023-11-10 10:46:08 ~1 min nix-flake 📄log
✖️ 996941c #5 2023-11-10 10:48:01 ~3 min tests 📄log
✔️ 996941c #6 2023-11-10 10:48:08 ~3 min android 📦tgz
✔️ 996941c #6 2023-11-10 10:48:15 ~3 min tests 📄log
✔️ 996941c #7 2023-11-10 10:49:18 ~4 min ios 📦tgz
✔️ 0efaf83 #8 2023-11-10 10:55:04 ~1 min nix-flake 📄log
✔️ 0efaf83 #8 2023-11-10 10:55:32 ~2 min linux 📦deb
✔️ 0efaf83 #7 2023-11-10 10:55:42 ~2 min tests 📄log
✔️ 0efaf83 #7 2023-11-10 10:56:29 ~3 min android 📦tgz
✔️ 0efaf83 #6 2023-11-10 10:57:15 ~4 min tests 📄log
✔️ 0efaf83 #8 2023-11-10 10:57:21 ~4 min ios 📦tgz
✔️ b469dae #9 2023-11-10 11:02:30 ~1 min linux 📦deb
✔️ b469dae #9 2023-11-10 11:03:16 ~1 min nix-flake 📄log
✔️ b469dae #7 2023-11-10 11:03:41 ~2 min tests 📄log
✔️ b469dae #8 2023-11-10 11:03:56 ~2 min tests 📄log
✔️ b469dae #8 2023-11-10 11:04:46 ~3 min android 📦tgz
✔️ b469dae #9 2023-11-10 11:05:37 ~4 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 98998e9 #10 2023-11-10 11:20:45 ~1 min linux 📦deb
✔️ 98998e9 #10 2023-11-10 11:21:32 ~1 min nix-flake 📄log
✔️ 98998e9 #8 2023-11-10 11:21:50 ~2 min tests 📄log
✔️ 98998e9 #9 2023-11-10 11:22:15 ~2 min tests 📄log
✔️ 98998e9 #9 2023-11-10 11:22:56 ~3 min android 📦tgz
✔️ 98998e9 #10 2023-11-10 11:23:46 ~4 min ios 📦tgz
✔️ 766f077 #11 2023-11-10 11:48:40 ~1 min linux 📦deb
✔️ 766f077 #11 2023-11-10 11:49:25 ~1 min nix-flake 📄log
✔️ 766f077 #9 2023-11-10 11:49:46 ~2 min tests 📄log
✔️ 766f077 #10 2023-11-10 11:50:01 ~2 min tests 📄log
✔️ 766f077 #10 2023-11-10 11:51:01 ~3 min android 📦tgz
✔️ 766f077 #11 2023-11-10 11:52:16 ~4 min ios 📦tgz

@vitvly vitvly force-pushed the chore/messages-logging branch 5 times, most recently from babcefd to 7fe4b24 Compare November 9, 2023 11:58
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Left a minor comment.

Also, is the logLevel configurable via a config option as well other than using env variable?

waku/v2/utils/logger.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as the comment is a minor one.

@vitvly vitvly force-pushed the chore/messages-logging branch 2 times, most recently from 0efaf83 to b469dae Compare November 10, 2023 11:01
@vitvly
Copy link
Contributor Author

vitvly commented Nov 10, 2023

@chaitanyaprem i just added an extra change that i forgot to push yesterday: b469dae . I think this line is redundant.

@vitvly vitvly force-pushed the chore/messages-logging branch from 98998e9 to 766f077 Compare November 10, 2023 11:47
@vitvly vitvly merged commit 684c7a4 into master Nov 10, 2023
3 checks passed
@vitvly vitvly deleted the chore/messages-logging branch November 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants