Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to swap nwaku for go-waku in tests #763

Merged
merged 9 commits into from
Aug 25, 2022
Merged

Make it easier to swap nwaku for go-waku in tests #763

merged 9 commits into from
Aug 25, 2022

Conversation

D4nte
Copy link
Contributor

@D4nte D4nte commented May 26, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented May 26, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 133.8 KB (0%) 2.7 s (0%) 3.3 s (+8.79% 🔺) 6 s
Waku default setup 306.58 KB (0%) 6.2 s (0%) 5.1 s (+24.11% 🔺) 11.3 s
Asymmetric, symmetric encryption and signature 133.17 KB (0%) 2.7 s (0%) 4.7 s (+135.15% 🔺) 7.4 s
DNS discovery 120.13 KB (+0.03% 🔺) 2.5 s (+0.03% 🔺) 3.3 s (+0.75% 🔺) 5.7 s
Privacy preserving protocols 133.17 KB (0%) 2.7 s (0%) 3.9 s (+41.41% 🔺) 6.6 s
Light protocols 134.52 KB (0%) 2.7 s (0%) 3.8 s (+11.99% 🔺) 6.5 s
History retrieval protocols 134.65 KB (0%) 2.7 s (0%) 3.7 s (+1.06% 🔺) 6.4 s

@D4nte
Copy link
Contributor Author

D4nte commented May 27, 2022

Blocked by waku-org/go-waku#247

@D4nte D4nte added the blocked This issue is blocked by some other work label May 27, 2022
@D4nte D4nte force-pushed the go-waku-drop-in branch 2 times, most recently from 54cc694 to 072fb04 Compare June 15, 2022 01:17
@fryorcraken
Copy link
Collaborator

protons is not performant so we may want to switch to protobufjs (fixed by ipfs/protons#58 ?)

This was pending ipfs/protons#48

@fryorcraken fryorcraken self-requested a review as a code owner August 19, 2022 14:46
@fryorcraken fryorcraken removed the blocked This issue is blocked by some other work label Aug 19, 2022
@fryorcraken fryorcraken force-pushed the go-waku-drop-in branch 6 times, most recently from 34c8d46 to ba898a3 Compare August 25, 2022 02:30
@fryorcraken fryorcraken merged commit 9f52d2b into master Aug 25, 2022
@fryorcraken fryorcraken deleted the go-waku-drop-in branch August 25, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fryorcraken fryorcraken Awaiting requested review from fryorcraken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D4nte @fryorcraken