Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deliverable] DoS protection for req-res protocols and metrics (go-waku as service node) #200

Open
3 of 4 tasks
chair28980 opened this issue Jun 5, 2024 · 4 comments
Open
3 of 4 tasks
Labels
Deliverable Tracks a Deliverable

Comments

@chair28980 chair28980 added the Deliverable Tracks a Deliverable label Jun 5, 2024
@fryorcraken fryorcraken added this to Waku Jun 5, 2024
@chair28980 chair28980 moved this to In Progress in Waku Aug 19, 2024
@fryorcraken
Copy link
Contributor

Is this done?
What parameters are set in Status apps?
Since what release?

@richard-ramos
Copy link
Member

Looking at the code, the rate limit is set for lightpush and peer-exchange.
Both of these with 1 request per second.

This was added 4 months ago in the following PRs (cc: @vpavlin)
status-im/status-go#5504
status-im/status-go#5504

These are available since release v2.30

It's missing for filter. Should be relatively straightfwd to implement so we get it on the next release.

@fryorcraken
Copy link
Contributor

cc @chaitanyaprem should we review the 1 req per sec to a higher limit?

@chaitanyaprem
Copy link

chaitanyaprem commented Dec 17, 2024

cc @chaitanyaprem should we review the 1 req per sec to a higher limit?

I have already increased for publishing and filter side. Will have to increase for lightpush service-node side as well until we bring in rln.

Including it as part of status-im/status-go#5964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deliverable Tracks a Deliverable
Projects
Status: In Progress
Development

No branches or pull requests

4 participants