You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondering if we should follow rate-limits similar to how they are sent in nwaku or use a smaller size than fleet nodes. @jm-clius@richard-ramos any thoughts?
IIUC this is mainly for the Status Desktop instances - hence the rate limits should be probably smaller than a fleet node - although 1 msg/s might be a bit too low:)
In other words, I'm not sure what the intended rate limits for the fleets are. 1 msg/second for Status Desktop nominally sounds reasonable, though this may require real world feedback to confirm. :)
In other words, I'm not sure what the intended rate limits for the fleets are. 1 msg/second for Status Desktop nominally sounds reasonable, though this may require real world feedback to confirm. :)
Yes, it is not applied yet.
We may need to open discussion on this topic as I'm just finished with the last phase of request rate limitation.
That will apply default per peer request rate for filter service.
lightpush and store and store legacy are default switched off.
There are number of questions how to apply DOS protection properly.
I think we cannot apply one single rule for lightpush and store.
Do we need separate CLI arguments or defaults?
RLN and dos protection are a bit competing feature: for lightpush we may consider different approach for DOS protection. The current solution is flexible on that.
What are the acceptable query rates for store service?
... probably there come more questions to discuss.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vpavlin
force-pushed
the
feat/add-lightpush-ratelimit
branch
3 times, most recently
from
This PR enables rate-limiting on Lightpush protocol with 1 msg/s rate.
Important changes:
Related to #4857