#485 make reading manifest optional in AnalysisScopeReader

[coder-chenzhi]

To resolve #485 , I have introduced two extra method for back-compatible. Please review it.

[msridhar]

You need to run ./gradlew goJF locally to format the code correctly with Google Java Format. You can also run ./gradlew installGitHooks to have GJF run locally on every commit.

[msridhar]

Can we add a regression test for this new code? Like package some classes into a .war file during testing and then try to load it?

[coder-chenzhi]

I have ran ./gradlew goJF to format the code and pushed the update to current branch.

We can use some existing simple war projects as test cases, such as sample1 and sample2. However, it seems that WALA does not support to load war files directly. In fact, I manually extract classes and libs under WEB-INF from war files and add them to AnalysisScope when performing the analysis. Is it necessary to add some helper classes to ease the analysis of war files?

[msridhar]

@coder-chenzhi what is your usage scenario? We used to have more J2EE support in WALA many years back but it was unmaintained and got removed. Beyond handling WAR files, usually you need to do things like model J2EE entrypoints, callbacks, etc. For your use case, is just including WAR files in the AnalysisScope good enough? If so, maybe we should expand this PR to allow that directly

[ghost]

Congratulations 🎉. DeepCode analyzed your code in 0.528 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot