Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shipped php.ini with php-production.ini from PHP 8.1 #404

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Kdecherf
Copy link
Member

No description provided.

Copy link
Contributor

@yguedidi yguedidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were there any customization made before that should be preserved?

@Kdecherf
Copy link
Member Author

@yguedidi I kept customizations :)

; http://php.net/session.gc-probability
session.gc_probability = 0
; https://php.net/session.gc-probability
session.gc_probability = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was set to 0 before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is overridden by Symfony anyway, see https://symfony.com/doc/5.x/session.html#configuring-garbage-collection

However, some operating systems (e.g. Debian) do their own session handling and set the session.gc_probability variable to 0 to stop PHP doing garbage collection. That's why Symfony now overwrites this value to 1.

@Kdecherf Kdecherf requested a review from yguedidi March 11, 2024 11:13
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf Kdecherf changed the base branch from master to 2.6.x March 11, 2024 11:47
@Kdecherf Kdecherf merged commit 19b6080 into 2.6.x Mar 11, 2024
4 checks passed
@Kdecherf Kdecherf deleted the impr/phpini branch March 11, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants