Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Maven properties aka resource filter #21

Closed
nahojkap opened this issue Feb 2, 2016 · 10 comments
Closed

Support for Maven properties aka resource filter #21

nahojkap opened this issue Feb 2, 2016 · 10 comments

Comments

@nahojkap
Copy link
Contributor

nahojkap commented Feb 2, 2016

Hi,

Would be nice to have an option to filter the MD files before generating the HTML - e.g. properties from the project, environment, etc.

Looks like it could be done while you read the MD files?

Thanks,

Johan

@walokra
Copy link
Owner

walokra commented Feb 4, 2016

That could be nice feature. Have to see if I find time for it or you can always make a pull request :)

@nahojkap
Copy link
Contributor Author

nahojkap commented Feb 4, 2016

Indeed, looked at doing just that but haven't found the time yet. ;)

nahojkap added a commit to nahojkap/markdown-page-generator-plugin that referenced this issue Dec 13, 2016
…ports crude filtering based on Maven properties
nahojkap added a commit to nahojkap/markdown-page-generator-plugin that referenced this issue Dec 13, 2016
@nahojkap
Copy link
Contributor Author

@walokra Not sure if this is the direction you'd see the plugin go but with these changes, it uses the Resources plugin style of replacing properties (in the form of ${some.property}) with the values defined in the pom.xml (or elsewhere).

walokra added a commit that referenced this issue Dec 17, 2016
#21 Support for Maven properties aka resource filter
@walokra
Copy link
Owner

walokra commented Dec 17, 2016

Thanks for the pull request. I think that the resources plugin style filtering suits nicely for the plugin.

@walokra walokra closed this as completed Dec 17, 2016
@nahojkap
Copy link
Contributor Author

nahojkap commented Dec 22, 2016

Great, thanks for merging - any chance of an official release? :)

@walokra
Copy link
Owner

walokra commented Dec 22, 2016

I'm planning to do a release in the coming weeks.

@nahojkap
Copy link
Contributor Author

+1 & thanks!

@nahojkap
Copy link
Contributor Author

hi @walokra - any chance for that release? :)

@walokra
Copy link
Owner

walokra commented May 13, 2017

The 1.0.0 release of the plugin should be found on Maven Central (since 2017-01-28).

@nahojkap
Copy link
Contributor Author

Hi @walokra - my bad, it is indeed there - many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants