Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce logging of List final flexmark options to debug level #63

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

jodygarnett
Copy link
Contributor

This resolves #60 ensuring normal execution of processMarkdown does not produce any INFO output.

Produces a single debug level message for for final flexmark option information

@jodygarnett
Copy link
Contributor Author

Aside: I tried looking up if maven was in batch mode, so we could selectively provide less feedback when not in an interactive environment, but did not find a useful example.

@walokra walokra merged commit 88c1703 into walokra:master Jul 2, 2021
@walokra
Copy link
Owner

walokra commented Jul 2, 2021

Thanks for the PR. In normal execution it's reasonable to produce less output and these log messages were indeed more of a debug type.

@jodygarnett
Copy link
Contributor Author

Thanks for merging, sorry I could not figure out how to detect if it is in batch mode (which would of provided the best of both worlds).

@juanluisrp
Copy link

Aside: I tried looking up if maven was in batch mode, so we could selectively provide less feedback when not in an interactive environment, but did not find a useful example.

@jodygarnett you can use the injected MavenSession session field to know if Maven is executed in interactive or batch mode:

this.session.getSettings().isInteractiveMode()

MdPageGeneratorMojo.java already have a session field available:

/**
* The maven session.
*/
@Component
protected MavenSession session;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbose final flexmark option INFO logging during plugin operation
3 participants