Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stick to old version #97

Merged
merged 1 commit into from
Aug 15, 2022
Merged

stick to old version #97

merged 1 commit into from
Aug 15, 2022

Conversation

wangfenjin
Copy link
Owner

cppjieba 新版本改成 submodule 了导致编译失败,先指定到特定版本

fix #74

@hxicoder 应该能修复你提到的问题

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #97 (a8908e4) into master (c61d24c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files           3        3           
  Lines         213      213           
=======================================
  Hits          204      204           
  Misses          9        9           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangfenjin wangfenjin merged commit 4b73ed1 into master Aug 15, 2022
@wangfenjin wangfenjin deleted the cppjieba-version branch August 15, 2022 08:13
@hxicoder
Copy link

cppjieba 新版本改成 submodule 了导致编译失败,先指定到特定版本

fix #74

@hxicoder 应该能修复你提到的问题

你好,感谢! 这个问题解决了,但是我有个疑问比较费解,就是pinyin.cc中有个头文件#include <cmrc/cmrc.h>,这个cmrc.h以及cpp实现为什么不能以源代码的形式呈现呢?如果能看到源代码的话更方便理解的吧

@wangfenjin
Copy link
Owner Author

cmrc 本身没什么逻辑,用它是因为想把 pinyin.txt 这个文件打包到 so 文件里面,不然的话用这个库还需要拷贝一个 txt 文件,使用上不方便。用编译流程是因为这样后续更新 pinyin.txt 比较方便

简单理解就是 cmrc 把 txt 文件变成了代码里面的一个二进制串 https://github.com/vector-of-bool/cmrc

@hxicoder
Copy link

cmrc 本身没什么逻辑,用它是因为想把 pinyin.txt 这个文件打包到 so 文件里面,不然的话用这个库还需要拷贝一个 txt 文件,使用上不方便。用编译流程是因为这样后续更新 pinyin.txt 比较方便

简单理解就是 cmrc 把 txt 文件变成了代码里面的一个二进制串 https://github.com/vector-of-bool/cmrc

这个我理解了,但我想到有种场景比如要调试下代码,跟一下代码流程,这样的话可能就比较麻烦了,所以是否考虑能在后续的版本迭代中加入cmrc.h和cmrc.cpp的实现呢,感觉这样是不是会更好些,这个仅仅是个人意见

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS使用问题
2 participants