Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rnn op unit test after refactoring framework proto. #5

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Modify rnn op unit test after refactoring framework proto. #5

merged 1 commit into from
Aug 10, 2017

Conversation

qingqing01
Copy link
Collaborator

Yang told me some work need to do in the PR #3. So this PR is to make the unit test pass for RNN Op.

  1. The unit test for RNN op forward was be deleted since it had been moved to Python.
  2. The unit test for backward will be rewritten and moved to Python.

@reyoung reyoung mentioned this pull request Aug 9, 2017
Merged
@wangkuiyi wangkuiyi merged commit 36709d0 into wangkuiyi:refactorize_framework_proto Aug 10, 2017
wangkuiyi pushed a commit that referenced this pull request Aug 19, 2017
@reyoung
Merge pull request #5 from jacquesqiao/fix-sgd
789263b 
Fix sgd
@qingqing01 qingqing01 deleted the rnn_test_for_refactorize_framework_proto branch March 7, 2018 12:04
wangkuiyi pushed a commit that referenced this pull request Mar 31, 2018
@jacquesqiao
Merge pull request #5 from typhoonzero/fix_server_shutdown
9583dc3 
Fix server shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingqing01 @wangkuiyi