-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include WIT bindings #1
Include WIT bindings #1
Conversation
The $ wapm validate .
Error: WASM file "./out/wasi/Debug/wasm-interp" detected as invalid because InterfaceViolated {
errors: [
"Missing import \"wasi_snapshot_preview1\" \"fd_close\"",
"Missing import \"wasi_snapshot_preview1\" \"fd_seek\"",
"Missing import \"wasi_snapshot_preview1\" \"fd_write\""
]
} |
@syrusakbary can you have a look through this PR to see if I'm doing things right? I've noticed that running |
|
||
[[command]] | ||
name = "wasm-strip" | ||
module = "wasm-strip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to add the wit-bindings as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought commands don't have bindings because they're intended as executables that people run, not libraries that people import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Packages can have both commands and libraries.
That means, that a package can have 3 CLI binaries (with WASI), and 1 library (with WIT), for example.
So basically, we can have a new libwabt
module that has bindings in the package :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that was already added yesterday before marking the PR ready. I'm guessing I forgot to push the code up.
Things look more or less right (to generate libwabt). I think that to generate the rest of WASI CLI files we need to use cmake (so we need to have that working) |
Do you mean the executables? The |
This PR updates the
wabt
embeddings to be in sync with the latest version ofwit-bindgen
(c047230). I've also included thewapm.toml
andREADME-wapm.md
that is present on WAPM.