Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

ライブラリを用いたシリアル化 #21

Merged
merged 13 commits into from
Nov 28, 2023
Merged

ライブラリを用いたシリアル化 #21

merged 13 commits into from
Nov 28, 2023

Conversation

warahiko
Copy link
Owner

課題

close #8

対応箇所

  • json_serializable を利用して、独自のクラスから API のリクエストを作成する
  • json_serializable を利用して、API のレスポンスを独自のクラスに変換する

動作

差分なし

warahiko
warahiko commented Nov 27, 2023
View reviewed changes
lib/main_screen.dart Outdated Show resolved Hide resolved
@warahiko warahiko marked this pull request as ready for review November 27, 2023 09:02
@github-actions GitHub Actions
Copy link

Ready for review 🚀

blendthink
blendthink reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warahiko
いくつかコメントさせていただきましたのでご確認お願いします 🙏

lib/model/fetch_weather_request.dart Show resolved Hide resolved
build.yaml Show resolved Hide resolved
lib/date_time_converter.dart Outdated Show resolved Hide resolved
analysis_options.yaml Outdated Show resolved Hide resolved
blendthink
blendthink approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です！
LGTM

@warahiko warahiko merged commit 3b23f5e into main Nov 28, 2023
2 checks passed
@warahiko warahiko deleted the feature/serialize branch November 28, 2023 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blendthink blendthink blendthink approved these changes

Assignees

@warahiko warahiko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session7
2 participants
@warahiko @blendthink