wardenenv/images#719 - Add PHP-SPX image build #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bap14
commented
Jan 29, 2024
nginx/etc/nginx/conf.d/default.conf
Outdated
| @@ -2,12 +2,17 @@ | |||
| resolver 127.0.0.11; | |||
|
|
|||
| # Select upstream backend to use based on presense of Xdebug cookies and Blackfire headers | |||
| map "$http_X_BLACKFIRE_QUERY:$cookie_XDEBUG_SESSION$cookie_XDEBUG_PROFILE$cookie_XDEBUG_TRACE$arg_XDEBUG_SESSION$arg_XDEBUG_SESSION_START" $fastcgi_backend { | |||
| map "$http_X_BLACKFIRE_QUERY:$cookie_XDEBUG_SESSION$cookie_XDEBUG_PROFILE$cookie_XDEBUG_TRACE$arg_XDEBUG_SESSION$arg_XDEBUG_SESSION_START:$cookie_SPX_ENABLED$cookie_SPX_KEY$arg_SPX_ENABLED$arg_SPX_KEY$arg_SPX_UI_URI" $fastcgi_backend { | |||
| volatile; | |||
There was a problem hiding this comment.
@navarr I was having issues with cookies not being respected; however, it could have been because of Varnish caching the requests. This line shouldn't need to be there.
|
What's the status of this PR? @navarr |
|
@MagePsycho held up until at minimum I fix PHP images not building |
|
@bap14, is there instruction how to use this image? :) |
|
@ihor-sviziev Not yet; however, now that the image is there it can move forward in being a toggled feature for projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new SPX image build. Adjusts Nginx configuration to route requests to the SPX container (similar to Xdebug), and prevents Varnish from caching SPX requests.