Skip to content

Commit

Permalink
Updated default PHP version for 'magento2' environments from 7.2 to 7.3
Browse files Browse the repository at this point in the history
  • Loading branch information
davidalger committed Jan 24, 2020
1 parent d0ba08b commit 2ba6f41
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* Updated Selenium setup for MFTF to use hub and headless nodes by default (issue [#67](https://github.com/davidalger/warden/issues/67); [#68](https://github.com/davidalger/warden/pull/68) by [lbajsarowicz](https://github.com/lbajsarowicz))
* Added Allure reporting support to Selenium setup for MFTF ([#69](https://github.com/davidalger/warden/pull/69) by [lbajsarowicz](https://github.com/lbajsarowicz))
* Updated environment templates to pass `TRAEFIK_DOMAIN` and `TRAEFIK_SUBDOMAIN` into `php-fpm` and `php-debug` for use in documented install routine (issue [#42](https://github.com/davidalger/warden/issues/42))

* Updated default PHP version for `magento2` environments from 7.2 to 7.3

**Bug fixes:**
* Fixed broken incorrect Blackfire environment template name for magento1 env type (issue [#48](https://github.com/davidalger/warden/issues/48))
Expand Down
2 changes: 1 addition & 1 deletion commands/env-init.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ if [[ "${WARDEN_ENV_TYPE}" == "magento2" ]]; then
ELASTICSEARCH_VERSION=6.8
MARIADB_VERSION=10.3
NODE_VERSION=10
PHP_VERSION=7.2
PHP_VERSION=7.3
RABBITMQ_VERSION=3.7.14
REDIS_VERSION=5.0
VARNISH_VERSION=4.1
Expand Down
4 changes: 2 additions & 2 deletions environments/magento2.base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ services:

php-fpm:
hostname: "${WARDEN_ENV_NAME}-php-fpm"
image: davidalger/warden:mage2-fpm-${PHP_VERSION:-7.2}
image: davidalger/warden:mage2-fpm-${PHP_VERSION:-7.3}
environment:
- TRAEFIK_DOMAIN
- TRAEFIK_SUBDOMAIN
Expand All @@ -58,7 +58,7 @@ services:

php-debug:
hostname: "${WARDEN_ENV_NAME}-php-debug"
image: davidalger/warden:mage2-fpm-${PHP_VERSION:-7.2}-debug
image: davidalger/warden:mage2-fpm-${PHP_VERSION:-7.3}-debug
environment:
- TRAEFIK_DOMAIN
- TRAEFIK_SUBDOMAIN
Expand Down
2 changes: 1 addition & 1 deletion environments/magento2.blackfire.base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: "3.5"
services:
php-blackfire:
hostname: "${WARDEN_ENV_NAME}-php-blackfire"
image: davidalger/warden:mage2-fpm-${PHP_VERSION:-7.2}-blackfire
image: davidalger/warden:mage2-fpm-${PHP_VERSION:-7.3}-blackfire
depends_on:
- db
networks:
Expand Down

1 comment on commit 2ba6f41

@davidalger
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #75

Please sign in to comment.