add regex for alternate typo of onchanges (#286)

warpnet · Dec 16, 2022 · 71c6e78 · 71c6e78
1 parent 42669e8
commit 71c6e78
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/saltlint/rules/TypoOnchangesRule.py b/saltlint/rules/TypoOnchangesRule.py
@@ -13,4 +13,4 @@ class TypoOnchangesRule(TypographicalErrorRule):
     shortdesc = '"onchange" looks like a typo. Did you mean "onchanges"?'
     description = '"onchange" looks like a typo. Did you mean "onchanges"?'
     version_added = 'v0.6.0'
-    regex = re.compile(r"^\s+- onchange(|_in|_any):")
+    regex = re.compile(r"^\s+- (on_?change(|_in|_any)|on_changes(|_in|_any)):")
diff --git a/tests/unit/TestTypoOnchangesRule.py b/tests/unit/TestTypoOnchangesRule.py
@@ -41,6 +41,20 @@
     - onchange_any:
         - yetanotherfile
         - onemorefile
+    - on_change:
+        - otherfile
+    - on_change_in:
+        - anotherfile
+    - on_change_any:
+        - yetanotherfile
+        - onemorefile
+    - on_changes:
+        - otherfile
+    - on_changes_in:
+        - anotherfile
+    - on_changes_any:
+        - yetanotherfile
+        - onemorefile
 '''
 
 class TestTypoOnchangesRule(unittest.TestCase):
@@ -56,4 +70,4 @@ def test_statement_positive(self):
 
     def test_statement_negative(self):
         results = self.runner.run_state(BAD_ONCHANGES_LINE)
-        self.assertEqual(3, len(results))
+        self.assertEqual(9, len(results))