-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add nested dictionary formating check #284
Conversation
913df48
to
0d84ca2
Compare
cacab91
to
312f009
Compare
Hi again @sblaisot! Thanks so much for your PR. Looks like you ticked all the right boxes on your PR as well! We'll try to do a code review as soon as we can, and integrate this new feature into our next release if it passes :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sblaisot! The PR looks good overall, I have made a few suggestions to avoid some false-positives and have correct versioning of the rule.
312f009
to
1a2a422
Compare
Thanks for review @matthijswendelaar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @sblaisot, I made a single suggestion to revert back to your original of 2 spaces of over-indentation required, instead of only 1 space of over-indentation required that I suggested.
After that the PR can be merged.
1a2a422
to
5327c4e
Compare
This pull request add a check on proper nested dictionary over-indentation as advised in https://docs.saltproject.io/en/latest/topics/troubleshooting/yaml_idiosyncrasies.html#nested-dictionaries
It adds Rule 219 (which seems to be the first never-used 2xx rule number). Feel free to change rule number if needed.
This fixes #282