Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: octal rule triggers on time format #303

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

nicholasmhughes
Copy link
Contributor

Time values such as this:

some_calendar_entry:
  file.managed:
    - name: /tmp/my_unit_file
    - contents: |
        OnCalendar=Sun 18:00

should not trigger this rule.

Changed the regex to accommodate this case while still catching/ignoring previous identified test cases

@nicholasmhughes
Copy link
Contributor Author

@roaldnefs

@roaldnefs roaldnefs self-requested a review January 3, 2024 17:40
nicholasmhughes and others added 2 commits January 3, 2024 18:50
Signed-off-by: Roald Nefs <info@roaldnefs.com>
@roaldnefs roaldnefs force-pushed the fix-octal-rule-for-time branch from c7c9341 to f738ccd Compare January 3, 2024 17:54
Signed-off-by: Roald Nefs <info@roaldnefs.com>
@roaldnefs roaldnefs force-pushed the fix-octal-rule-for-time branch from 0eed049 to ee39608 Compare January 3, 2024 18:03
Copy link
Member

@roaldnefs roaldnefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nicholasmhughes for your contribution! Unfortunately it took a while before I could find time for a review. I've rebased the code, added the missing changelog entry and made a minor change in the code.

@roaldnefs roaldnefs merged commit 2f12381 into warpnet:main Jan 3, 2024
7 checks passed
@nicholasmhughes nicholasmhughes deleted the fix-octal-rule-for-time branch January 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants