Links markers list dialogs as checklist #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +44,13 @@ const OperationChecklistDialog = WDialog.extend({ | |||
|
|
|||
| _displayDialog: async function () { | |||
| const operation = getSelectedOperation(); | |||
| this.sortable = this.getListDialogContent(operation, 0, false); // defaults to sorting by op order | |||
| loadFaked(operation); | |||
There was a problem hiding this comment.
isn't this too "automatic" for you?
There was a problem hiding this comment.
it is, this feature is controlled by the user settings (disabled by default)
I only moved the call from addHooks to _displayDialog
cloudkucooland
approved these changes
May 21, 2021
| @@ -268,9 +268,14 @@ const OperationChecklistDialog = WDialog.extend({ | |||
| }, | |||
| }, | |||
| ]; | |||
| }, | |||
|
|
|||
| getListDialogContent: function (operation, items, sortBy, sortAsc) { | |||
There was a problem hiding this comment.
elegant solution. I like it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link list and marker list dialog as checklist dialogs
I'm also considering having a
.getItemsfunction like.getFieldsNeed some audit on UI update.
We need to fix current update issues before (see #238)
Fix #239 #240 #242