Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added undo button after draw button in toolbar #381

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

adinlead
Copy link

@adinlead adinlead commented Aug 9, 2024

  1. Enlarged the delete button icon
  2. Added open-source redo and undo icons (from Bootstrap)

2. Enlarged the delete button icon
3. Added open-source redo and undo icons (from Bootstrap)
@cloudkucooland
Copy link
Member

Looks good to me. @le-jeu can approve

@le-jeu
Copy link
Member

le-jeu commented Aug 9, 2024

Thank you for your contribution. I'll give a look as soon as I'm able to.

I will rebase your PR on the dev build from the github interface (unless you do it first).

@le-jeu
Copy link
Member

le-jeu commented Aug 18, 2024

The redo icon is not used.
Could the undo button be disabled/grayed when there is nothing to undo ?

@adinlead
Copy link
Author

adinlead commented Aug 19, 2024

The redo icon is not used. Could the undo button be disabled/grayed when there is nothing to undo ?

This is a good suggestion, currently there is no such design available
I will try to implement it later, please wait a moment

====================

  • When unable to undo, disable undo button

@le-jeu
Copy link
Member

le-jeu commented Aug 24, 2024

The redo icon is not used.

In fact, according to analytics, the redo feature is not used that much so I think we don't need a button for it.
Either way, I'm not sure about the button design as it's more like a play backward button than an undo icon that uses to look as a curved left arrow.

You may also remove the debug/console.log lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants