Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simd): update SIMD opcodes #92

Merged
merged 1 commit into from
Mar 4, 2021
Merged

fix(simd): update SIMD opcodes #92

merged 1 commit into from
Mar 4, 2021

Conversation

ngzhian
Copy link
Contributor

@ngzhian ngzhian commented Mar 2, 2021

See WebAssembly/simd#452 for finalized opcodes
and WebAssembly/simd#467 for some renamings.

@ngzhian
Copy link
Contributor Author

ngzhian commented Mar 2, 2021

Where do the .wasm files in __fixtures__ come from? Some of them need to be updated. I'm still running the tests and updating snapshot, will rebase later.

@bmeurer
Copy link
Collaborator

bmeurer commented Mar 3, 2021

Where do the .wasm files in __fixtures__ come from? Some of them need to be updated. I'm still running the tests and updating snapshot, will rebase later.

Those are generated by jest. You can pass -u to jest to rebaseline them.

@yurydelendik
Copy link
Collaborator

yurydelendik commented Mar 3, 2021 •
edited
Loading

fixes #90

We probably want to disable some wabt tests. wasmparser.rs disables (until tools settle): simd_boolean.wast, simd_lane.wast, simd_i16x8_arith2.wast, simd_f64x2_rounding.wast, simd_f32x4_rounding.wast.

@ngzhian
fix(simd): update SIMD opcodes
ddca519 
See WebAssembly/simd#452 for finalized opcodes
and WebAssembly/simd#467 for some renamings.
@ngzhian
Copy link
Contributor Author

ngzhian commented Mar 3, 2021

Updated with some tests disabled.

@ngzhian
Copy link
Contributor Author

ngzhian commented Mar 4, 2021

It looks like I can't merge this, please help me :) thanks!

@bmeurer bmeurer merged commit 648fff5 into wasdk:master Mar 4, 2021
@bmeurer
Copy link
Collaborator

bmeurer commented Mar 4, 2021

Done, thanks!

@yurydelendik
Copy link
Collaborator

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ngzhian ngzhian deleted the update-simd branch March 4, 2021 17:22
@ngzhian ngzhian mentioned this pull request Mar 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurydelendik yurydelendik yurydelendik approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngzhian @bmeurer @yurydelendik