Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding new spark color tokens and opinions theme #665

Merged
merged 7 commits into from
Sep 20, 2024
Merged

feat: Adding new spark color tokens and opinions theme #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e0418c2
feat:added spark color and opinion theme
BrianAA Sep 20, 2024
d60eed1
formatting changes
BrianAA Sep 20, 2024
65b10ec
bumped asset package and added postpulse to logo list
BrianAA Sep 20, 2024
048de63
formatting
BrianAA Sep 20, 2024
129b61e
added the seven logos to logo list
BrianAA Sep 20, 2024
c427d19
added seven logo to logo list
BrianAA Sep 20, 2024
38ee136
updated name of the seven on logo list
BrianAA Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions build.washingtonpost.com/components/Markdown/Examples/ColorSamples.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@ import { useTheme } from "next-themes";
const xMapping = [0, 20, 40, 60, 80, 100, 200, 300, 400, 500, 600, 700];
const yMapping = [
"red",
"blue",
"green",
"spark",
"orange",
"teal",
"gold",
"mustard",
"gold",
"yellow",
"green",
"teal",
"blue",
"purple",
"pink",
"yellow",
"gray",
];

Expand Down
4 changes: 4 additions & 0 deletions build.washingtonpost.com/components/Markdown/Examples/LogoSamples.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ export const logoList = [
"helpdesk-bw",
"helpdesk-primary",
"helpdesk-secondary",
"postpulse",
"the7-black",
"the7-blue",
"the7",
];

export const darkLogos = [
Expand Down
66 changes: 53 additions & 13 deletions build.washingtonpost.com/components/Markdown/Examples/ThemeTokens.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const Label = styled("div", {
export default function ThemeAndSemantic() {
return (
<Layout>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
Primary (-hover)
</Label>
Expand All @@ -48,8 +48,10 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Label css={{ color: theme.colors.onBackground }}>Secondary</Label>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
Secondary (-hover)
</Label>
<Container
css={{
border: `1px solid ${theme.colors.outline}`,
Expand All @@ -73,7 +75,7 @@ export default function ThemeAndSemantic() {
</Container>
</Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>Cta</Label>
<Label css={{ color: theme.colors.onBackground }}>Cta (-hover)</Label>
<Container
css={{
height: "100%",
Expand All @@ -91,7 +93,7 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>ctaContainer</Label>
<Container
css={{
Expand All @@ -113,7 +115,45 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
Opinions (-hover)
</Label>
<Container
css={{
border: `1px solid ${theme.colors.outline}`,
background: theme.colors.opinions,
transition: "background .15s",
"&:hover": {
background: theme.colors["opinions-hover"],
},
}}
>
<Label css={{ color: theme.colors.onOpinions }}>onOpinons</Label>
<Label css={{ color: theme.colors["onOpinions-hover"] }}>
onOpinons-hover
</Label>
</Container>
</Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
opinionsContainer
</Label>
<Container
css={{
border: `1px solid ${theme.colors.opinions}`,
background: theme.colors.opinionsContainer,
}}
>
<Label css={{ color: theme.colors.onOpinionsContainer }}>
onOpinionsContainer
</Label>
<Label css={{ color: theme.colors["onOpinionsContainer-hover"] }}>
onOpinons-hover
</Label>
</Container>
</Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>Background</Label>
<Container
css={{
Expand All @@ -133,7 +173,7 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
Background-forSurfaces
</Label>
Expand All @@ -155,7 +195,7 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>Surface</Label>
<Container
css={{
Expand All @@ -171,7 +211,7 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
Surface-highest
</Label>
Expand Down Expand Up @@ -210,7 +250,7 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>errorContainer</Label>
<Container
css={{
Expand All @@ -236,7 +276,7 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
successContainer
</Label>
Expand Down Expand Up @@ -264,7 +304,7 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
warningContainer
</Label>
Expand Down Expand Up @@ -292,7 +332,7 @@ export default function ThemeAndSemantic() {
</Label>
</Container>
</Box>
<Box>
<Box css={{ display: "flex", flexDirection: "column", height: "100%" }}>
<Label css={{ color: theme.colors.onBackground }}>
signalContainer
</Label>
Expand Down
2 changes: 1 addition & 1 deletion build.washingtonpost.com/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@washingtonpost/site-favicons": "0.3.4-alpha.1",
"@washingtonpost/site-footer": "0.25.3-alpha.1",
"@washingtonpost/tachyons-css": "^1.8.0",
"@washingtonpost/wpds-assets": "^2.5.0",
"@washingtonpost/wpds-assets": "^2.6.0",
"@washingtonpost/wpds-kitchen-sink": "2.7.0",
"@washingtonpost/wpds-tailwind-theme": "2.7.0",
"@washingtonpost/wpds-tokens": "2.7.0",
Expand Down
30 changes: 28 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@react-types/combobox": "^3.11.1",
"@react-types/shared": "^3.23.1",
"@stitches/react": "1.3.1-1",
"@washingtonpost/wpds-assets": "^2.5.0",
"@washingtonpost/wpds-assets": "^2.6.0",
"match-sorter": "6.3.1",
"nanoid": "^3.3.4",
"popper-max-size-modifier": "^0.2.0",
Expand Down
Loading
Loading