-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to run on Apple silicon #25
Conversation
I would rather provide an option to specify a custom path to wasm-pack, instead of trying to auto-detect things. Also, note that |
I agree that would be better 😄 - I'll take a look at how to do it. This is an easy fix in the wasm-pack package... however to get that updated is probably unlikely. The reason for moving it to an optional dependency is that |
Ok.. so I've updated to add a I actually realized it that it will run ok so long as wasm-pack is installed globally... so if you wanted to keep it simple all that needs to be changed for it to work is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking a lot better, just a few minor things to fix.
ok should be addressed. |
Thanks! |
Hi,
This allows the use of the plugin on macOS with Apple silicon and addresses #24. While the issue has nothing to do with this package (the cause is the wasm-pack npm package will throw on macOS unless
arch === "x64"
), it provides a work around where the user can use their local installation ofwasm-pack
.One thing to also note is the following exception that throws
Error: no prebuilt wasm-opt binaries are available for this platform: Unrecognized target!
. However this can also be fixed by adding the following in theCargo.toml
: