This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
v0.27.0: Bumped async_nats 0.30, wasmbus-rpc 0.14 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
bump/v0.27.0
branch
from
721120e to
9a369b7
Compare
10 tasks
brooksmtownsend
force-pushed
the
bump/v0.27.0
branch
from
9a369b7 to
b7f3d8e
Compare
brooksmtownsend
requested review from
autodidaddict and
connorsmith256
as code owners
Signed-off-by: Brooks Townsend <brooks@cosmonic.com> moved types from wasmbus_rpc Signed-off-by: Brooks Townsend <brooks@cosmonic.com> removed extra use statement Signed-off-by: Brooks Townsend <brooks@cosmonic.com> bumped control interface to nats 0.30 Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
brooksmtownsend
force-pushed
the
bump/v0.27.0
branch
from
b7f3d8e to
9f6b22b
Compare
connorsmith256
approved these changes
Jul 14, 2023
| @@ -65,10 +65,10 @@ pub(crate) async fn get_links(store: &Store) -> Result<LinkDefinitionList> { | |||
| pub(crate) async fn put_link(store: &Store, ld: LinkDefinition) -> Result<()> { | |||
| let id = ld_hash(&ld); | |||
| let key = format!("{}{}", LINKDEF_PREFIX, id); | |||
| store | |||
| Ok(store | |||
There was a problem hiding this comment.
This gave me an error when compiling, something about error types, which seemed easiest to correct like this. Kinda strange.
Edit: this was the cargo recommendation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
async_natsto main, which will soon be released as 0.30.0. It also moves some types fromwasmbus-rpcto this crate so we can avoid blocking / conflicting dependencies.This is a breaking change because the
LinkDefinitiontype is now exported from this crate and fromwasmbus_rpc, so if you're using both you will need to alias the struct. This shouldn't be an issue for most scenarios, but https://github.com/wasmCloud/wash is one project that both interacts with a lattice for RPC and for control interface commands, so it's something to consider.