This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
feat!(kv): Adds caching option for the interface client #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
requested review from
autodidaddict,
brooksmtownsend and
connorsmith256
as code owners
This PR does several things and contains several breaking changes: - All deprecated methods have now been removed. This means we no longer support the old method of getting linkdefs and claims via control topics - The function signatures for getting links and claims have changed to not use the old nested types. As part of this, nested types have been removed as well. - To support both cached and uncached clients, the `Client` and `ClientBuilder` types now have a generic `T` parameter. In practice this shouldn't actually affect most consumers, but will break those who are embedding it inside of other structs Obviously the biggest feature add here is that we now have a client option that allows you to cache all of the linkdefs and claims locally. This is already done in several wasmcloud projects (like the host and wadm) and so it made sense to just centralize this logic. The default client still does a direct request to the key value bucket so consumers like `wash` don't have to take the time to do the initial load of the entire cache I have bumped the crate to be an rc.1 because I want to make sure this is thoroughly tested in at least wadm (and preferrably the host) before cutting a full version Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
feat/cache
branch
from
9eab798 to
b72dcb4
Compare
connorsmith256
approved these changes
Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things and contains several breaking changes:
ClientandClientBuildertypes now have a genericTparameter. In practice this shouldn't actually affect most consumers, but will break those who are embedding it inside of other structsObviously the biggest feature add here is that we now have a client option that allows you to cache all of the linkdefs and claims locally. This is already done in several wasmcloud projects (like the host and wadm) and so it made sense to just centralize this logic. The default client still does a direct request to the key value bucket so consumers like
washdon't have to take the time to do the initial load of the entire cacheI have bumped the crate to be an rc.1 because I want to make sure this is thoroughly tested in at least wadm (and preferrably the host) before cutting a full version