This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
chore!: remove prov_rpc_host #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
connorsmith256
requested review from
autodidaddict and
brooksmtownsend
as code owners
|
I’m going to be rolling out some changes in the client next week so let’s not cut 0.31 until next week if we can |
thomastaylor312
approved these changes
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
The host is dropping support for a separate
prov_rpcNATS connection. See wasmCloud/wasmCloud#774 for motivationRelated Issues
wasmCloud/wasmCloud#774
Release Information
v0.31.0, since this is a compile-time breaking change
Consumer Impact
Since the field is optional in this client, the host can stop sending data before consumers of this crate are updated
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification