Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(handler): Resolving the race condition where handler is not initialization #21

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

ritesh089
Copy link
Contributor

This PR resolves the race condition that causes the below issue :
wasmCloud/wasmCloud#2374

This will prevent the onLink events from being triggered before the provider is completely initialized.

Feature or Problem

Related Issues

<!---
Link to any issues or correlated pull requests that are related to this PR. For example, if this PR fixes an issue, link to that issue here.
--->

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

@ritesh089 ritesh089 requested a review from a team as a code owner June 24, 2024 21:20
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple thoughts on keeping the current structure + establishing the links on start

provider.go Outdated Show resolved Hide resolved
provider.go Outdated Show resolved Hide resolved
provider.go Outdated Show resolved Hide resolved
…ialized

Signed-off-by: Ritesh Rai <ritesh.rai@aexp.com>
provider.go Outdated Show resolved Hide resolved
provider.go Outdated Show resolved Hide resolved
provider.go Outdated Show resolved Hide resolved
Signed-off-by: Ritesh Rai <ritesh.rai@aexp.com>
…ialized

Signed-off-by: Ritesh Rai <ritesh.rai@aexp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants