Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(schema): change name and description on json schema #395

Merged

Conversation

lachieh
Copy link
Contributor

@lachieh lachieh commented Aug 20, 2024

Feature or Problem

Manifest name shows up in IDE's as "Manifest" which isn't very helpful.

Related Issues

nada

@lachieh lachieh requested a review from a team as a code owner August 20, 2024 16:05
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@brooksmtownsend
Copy link
Member

@lachieh just need a DCO from ya

Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
@lachieh lachieh force-pushed the chore/manifest-name-and-desc branch from 9de17a5 to d58d726 Compare August 20, 2024 17:23
@lachieh
Copy link
Contributor Author

lachieh commented Aug 20, 2024

thanks, done

@brooksmtownsend brooksmtownsend merged commit b78d4bf into wasmCloud:main Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants