deps(async-nats): upgrade to 0.36 #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
feat/upgrade-async-nats
branch
from
6b62ec8
to
627a09d
Compare
|
Currently failing on likely a breaking change updating to 0.36 https://github.com/nats-io/nats.rs/releases/tag/async-nats%2Fv0.36.0, which shouldn't be an issue I just need to pull out the stream message instead of deserializing the bytes directly edit: Yep this was it! So instead of base64 decoding some bytes and then deserializing, now we can just deserialize. Whee |
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
|
Done in #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR upgrades to async-nats 0.36, which will stay in draft until wasmcloud-control-interface 1.1.0 is released
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification