Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wadm)!: support configuring max stream bytes #418

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

brooksmtownsend
Copy link
Member

Feature or Problem

This PR surfaces additional command line flags & environment variables for configuring the creation of NATS streams and KV buckets with a maximum amount of bytes. By default there is no limit, but depending on the NATS deployment, operators may want to (or need to) supply this parameter.

I hid these variables by default because they are very verbose, but I plan on referencing them in documentation.

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@ahmedtadde
Copy link
Contributor

ahmedtadde commented Sep 17, 2024

hey @brooksmtownsend if time permits, can you please give a brief on what instigated this change. On the surface, it seems like just a prudent thing to do, which is totally fine. Just curious if this a precursor to something else that's coming up or a fix for something.

@brooksmtownsend
Copy link
Member Author

brooksmtownsend commented Sep 17, 2024

Ah @ahmedtadde yep! Mostly what instigated this was #417, we had a dev in the wasmCloud slack who wanted to use https://www.synadia.com/ for their NATS infrastructure and you have to supply the max_bytes parameter for creating the streams. It would probably be helpful to have a script that creates these streams based on this configuration so you can pre-create the streams in any NATS infra. The key discovery here too was that we can reuse the existing stream, so creating ahead of time will work just fine

@brooksmtownsend brooksmtownsend merged commit 5719f0e into main Sep 17, 2024
4 checks passed
@brooksmtownsend brooksmtownsend deleted the feat/configurable-max-bytes branch September 17, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants