chore: Revise the default NATS Server address logic #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas
force-pushed
the
chore/default-nats-address
branch
3 times, most recently
from
367e705
to
ef69ebf
Compare
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
joonas
force-pushed
the
chore/default-nats-address
branch
from
ef69ebf
to
726fba5
Compare
brooksmtownsend
approved these changes
Sep 19, 2024
protochron
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
As it turns out,
127.0.0.1:4222isn't a terribly helpful default.Instead, the most common scenario we see today is one where wadm is installed in the same namespace as the NATS Servers running in the cluster, so we should simply attempt to use that address instead.
This behavior can still be overridden as before, by providing a value via
wadm.config.nats.serverRelated Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification