build: remove nix
store paths from releases
#638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
nix flake show
secret-key-base
hack, use actual env variables and--impure
/nix/store
references from Elixir releases. This one is a fun one, Elixir is used to build the project and then copies itself to the release - we would not be able to build using "patched" Elixir, since/bin/sh
etc. does not (and should not) exist innix
sandbox during build, therefore we patch these out as part of themix
buildRelated Issues
Release Information
Consumer Impact
Testing
Pull an artifact from a CI run as usual and test in a Docker container, e.g.
docker run --rm -it -v$(pwd):$(pwd) -w$(pwd) ubuntu
from a directory containing the binary. Run (let it fail) and inspect~/.local/share/.burrito/*
. Currently there's just one shebang withnix
store ref, in cgi handler, but we should not use that anywayBuilt on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
See
Testing