Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove nix store paths from releases #638

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Jun 7, 2023

Feature or Problem

  • fix nix flake show
  • remove the secret-key-base hack, use actual env variables and --impure
  • remove /nix/store references from Elixir releases. This one is a fun one, Elixir is used to build the project and then copies itself to the release - we would not be able to build using "patched" Elixir, since /bin/sh etc. does not (and should not) exist in nix sandbox during build, therefore we patch these out as part of the mix build

Related Issues

Release Information

Consumer Impact

Testing

Pull an artifact from a CI run as usual and test in a Docker container, e.g. docker run --rm -it -v$(pwd):$(pwd) -w$(pwd) ubuntu from a directory containing the binary. Run (let it fail) and inspect ~/.local/share/.burrito/*. Currently there's just one shebang with nix store ref, in cgi handler, but we should not use that anyway

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

See Testing

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs marked this pull request as ready for review June 7, 2023 12:46
flake.nix Show resolved Hide resolved
@brooksmtownsend brooksmtownsend merged commit 5f13500 into wasmCloud:main Jun 13, 2023
@rvolosatovs rvolosatovs deleted the fix/flake branch July 21, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants