Fixed adding provider from file bug #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aish-where-ya <aharpale@cosmonic.com>
aish-where-ya
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
connorsmith256
as code owners
|
@aish-where-ya I'm not sure why dialyzer is failing; I suspect the cache is poisoned for some reason. Would you mind opening these changes in a new PR so we can see if that clears things up? |
If cache is poisoned we may want to try clearing that out... let's see if we can delete these caches and re-run |
|
Ah, found some caches in GHA and cleared them out. 🤞 |
brooksmtownsend
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Bug: Provider could not be added using a file reference like
file:\\provider-file.par.gzThis bug has been fixed.
Related Issues
#639
wasmCloud/wash#540
Release Information
Next
Consumer Impact
Bug fix enabling starting a provider from file.
Testing
Manually tested
Built on platform(s)
Tested on platform(s)
Unit Test(s)
NA
Acceptance or Integration
NA
Manual Verification
Manually verified