-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(native): switch to wasmcloud-otp
#644
Conversation
13d016d
to
ee0fac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd made similar changes to my own PR, but I didn't think about the nix flake. Good catch
LGTM so long as the build passes |
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
The CI in this repo was broken for a while apparently, as I mentioned earlier (at least for now) updates to |
Can this get fixed?
|
rusterlium/rustler#544 Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
The issue is that OTP version used by CI is non-deterministic. Note, how it works just fine within Nix sandbox (because OTP version is locked) |
I don't follow. @rvolosatovs are you saying you expect CI to fail with this change? Do we need to/can we upgrade rustler to fix it? |
No. CI running outside Nix sandbox failed before a8df2c5, see https://github.com/wasmCloud/wasmcloud-otp/actions/runs/5622887410/job/15236382057 for example. |
So I am still a bit fuzzy... @rvolosatovs is this something that you're comfortable merging, and saying that the 2 failing items (so far) are things we can safely ignore? |
I do not see any failures, CI is still running |
Yay for eventually consistent GUI. Github was showing me 2 failed runs but when I refreshed the status changed to "expected" |
Feature or Problem
Related Issues
closes #640
Release Information
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification