Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting fs in WASI config #303

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Allow setting fs in WASI config #303

merged 4 commits into from
Nov 18, 2022

Commits on Sep 7, 2022

  1. [feature] Allow setting fs in WASI config. 

    Using some boilerplate to get the instance from a JS object.
    @corwin-of-amber
    corwin-of-amber committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    80dc150 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Added test for setting config.fs.

    @corwin-of-amber
    corwin-of-amber committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    52d4bc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. [bugfix] Dangling pointer when passing fs instance to Rust. 

    The JS instance becomes unusable, and trying to access it from JS leads to read from freed memory.
Since MemFS is garbage-collected anyway (via Arc) it makes sense to clone the reference.
JS clients should explicitly free if they do not want to use the fs instance anymore,
to have the reference count decremented.
    @corwin-of-amber
    corwin-of-amber committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    8278302 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. [feature] Improved error reporting in generic_of_jsval. 

    Used e.g. when passing MemFS via config.
    @corwin-of-amber
    corwin-of-amber committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ad578a6 View commit details
    Browse the repository at this point in the history