-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement the WasmArrayBuffer
class
#35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
🎉 enhancement
New feature or request
🧪 tests
I love tests
📦 component-extension
About the PHP extension written in C/C++
labels
Mar 25, 2019
Using `calloc` instead of `malloc` alows to initialize the buffer with zero bytes, which is better for the security: The buffer won't allow to read existing in-memory data.
@Hywan just a note on the OP:
|
Ocramius
suggested changes
Mar 26, 2019
Thanks @Ocramius for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 component-extension
About the PHP extension written in C/C++
📚 documentation
Do you like to read?
🎉 enhancement
New feature or request
🧪 tests
I love tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
WasmArrayBuffer
andWasmTypedArray
classes i.e.WasmInt8Array
,WasmUint8Array
,WasmInt16Array
,WasmUint16Array
,WasmInt32Array
andWasmUint32Array
.Prototype:
Example:
The code is highly inspired by http://www.phpinternalsbook.com/classes_objects/implementing_typed_arrays.html, with bug fixes and written for Zend Engine 3.