Remove Unused Import #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting around Rust 1.73 (I think) compiling wasmer started giving this error:
Compiling wasmer v1.0.0 (/Users/{user}/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/wasmer-1.0.0/crates/wasmer)
error: unused import: `ClassInfo`
--> crates/wasmer/src/prelude.rs:3:62
|
3 | pub use rutie_derive::{rubyclass, rubyfunction, rubymethods, ClassInfo, UpcastRubyClass};
| ^^^^^^^^^
|
This seems to just be an unused struct. Removing it makes it compile and
everything still seems to work when I use the lib (test suite fails but it
does under older versions of Rust as well so I don't think that is related).
syrusakbary
approved these changes
Mar 9, 2024
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting around Rust 1.75 (I think) compiling wasmer started giving this error:
This seems to just be an unused struct. Removing it makes it compile and everything still seems to work when I use the lib (test suite fails but it does under older versions of Rust as well so I don't think that is related).
This will fix #76.