Implement From<BinaryReaderError> for CompileError

lib/compiler/src/translator/error.rs

@@ -1,4 +1,4 @@
-use crate::WasmError;
+use crate::{CompileError, WasmError};
 use wasmparser::BinaryReaderError;
 
 /// Return an `Err(WasmError::Unsupported(msg))` where `msg` the string built by calling `format!`
@@ -16,3 +16,43 @@ impl From<BinaryReaderError> for WasmError {
         }
     }
 }
+
+impl From<BinaryReaderError> for CompileError {
+    fn from(original: BinaryReaderError) -> Self {
+        // `From` does not seem to be transitive by default, so we convert
+        // BinaryReaderError -> WasmError -> CompileError
+        Self::from(WasmError::from(original))
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use wasmparser::BinaryReader;
+
+    #[test]
+    fn can_convert_binary_reader_error_to_wasm_error() {
+        let mut reader = BinaryReader::new(b"\0\0\0\0");
+        let binary_reader_error = reader.read_bytes(10).unwrap_err();
+        match WasmError::from(binary_reader_error) {
+            WasmError::InvalidWebAssembly { message, offset } => {
+                assert_eq!(message, "Unexpected EOF");
+                assert_eq!(offset, 0);
+            }
+            err => panic!("Unexpected error: {:?}", err),
+        }
+    }
+
+    #[test]
+    fn can_convert_binary_reader_error_to_compile_error() {
+        let mut reader = BinaryReader::new(b"\0\0\0\0");
+        let binary_reader_error = reader.read_bytes(10).unwrap_err();
+        match CompileError::from(binary_reader_error) {
+            CompileError::Wasm(WasmError::InvalidWebAssembly { message, offset }) => {
+                assert_eq!(message, "Unexpected EOF");
+                assert_eq!(offset, 0);
+            }
+            err => panic!("Unexpected error: {:?}", err),
+        }
+    }
+}