Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill Emscripten Syscalls for Windows #176

Closed
16 tasks
xmclark opened this issue Feb 14, 2019 · 2 comments
Closed
16 tasks

Polyfill Emscripten Syscalls for Windows #176

xmclark opened this issue Feb 14, 2019 · 2 comments
Labels
ℹ️ help wanted Extra attention is needed 📦 lib-emscripten About wasmer-emscripten 🖼️ platform-windows This issue happens on Windows priority-low Low priority issue 🏚 stale Inactive issues or PR

Comments

@xmclark
Copy link
Contributor

xmclark commented Feb 14, 2019

This issue is related to #51, windows support. When PR #175 lands, wasmer will have experimental support for windows! This is exciting, but does not mean work is finished. Wasmer will only be able to run simple programs that do not use Emscripten, so no nginx or lua. The reason is that the required syscalls have not been implemented for the Windows target.

There are stubs left for unimplemented functions. Not all of the functions make sense on windows, so a more documented stub should be created if that is what is required. The end result is being able to run programs like nginx and lua, which also means that we can run the existing integration tests. When the stubs are filled and tests are passing, we can close this issue.

The to-be-implemented functions are listed below. The functions should be at least partially tested.

https://github.com/wasmerio/wasmer/blob/master/lib/emscripten/src/syscalls/windows.rs:

  • chown
  • mkdir
  • getgid
  • getgid32
  • dup3
  • ioctl
  • socketcall
  • pread
  • pwrite
  • wait4
  • select
  • setpgid
  • uname

https://github.com/wasmerio/wasmer/blob/master/lib/emscripten/src/io/windows.rs:

  • printf

Enable the tests:

  • emscripten tests
  • integration tests
@xmclark xmclark added the ℹ️ help wanted Extra attention is needed label Feb 14, 2019
nlewycky added a commit that referenced this issue Aug 13, 2020
Initial commit of fuzzers using `cargo fuzz`.
@Hywan Hywan added 📦 lib-emscripten About wasmer-emscripten 🖼️ platform-windows This issue happens on Windows labels Jul 13, 2021
@Amanieu Amanieu added the priority-low Low priority issue label Oct 20, 2021
@stale
Copy link

stale bot commented Oct 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Oct 20, 2022
@stale
Copy link

stale bot commented Nov 19, 2022

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ℹ️ help wanted Extra attention is needed 📦 lib-emscripten About wasmer-emscripten 🖼️ platform-windows This issue happens on Windows priority-low Low priority issue 🏚 stale Inactive issues or PR
Projects
None yet
Development

No branches or pull requests

3 participants