Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs issue: diagrams not readable in dark theme #2029

Closed
Spoonbender opened this issue Jan 18, 2021 · 1 comment · Fixed by #2041
Closed

Docs issue: diagrams not readable in dark theme #2029

Spoonbender opened this issue Jan 18, 2021 · 1 comment · Fixed by #2041
Assignees
Labels
bug Something isn't working 📚 documentation Do you like to read?

Comments

@Spoonbender
Copy link

The diagrams found here are not readable when viewing GitHub using the dark theme.

Steps to reproduce:

  1. Set your GitHub appearance preferences to use dark mode
  2. Browse to the wasmer examples readme.md at https://github.com/wasmerio/wasmer/blob/master/examples/README.md
  3. Attempt to read the text inside the diagram blocks (see screenshot below)

Expected behavior:
Reading succeeds and the information is conveyed.

Actual behavior:
Reading fails and the Wasmer main workflows remain a mystery.

Possible workarounds:

  1. Configure light theme on your GitHub appearance preferences, or
  2. Browse the docs in Incognito mode

image

@Spoonbender Spoonbender added the bug Something isn't working label Jan 18, 2021
@Hywan Hywan self-assigned this Jan 22, 2021
@Hywan Hywan added the 📚 documentation Do you like to read? label Jan 22, 2021
@bors bors bot closed this as completed in 4378b22 Jan 22, 2021
@syrusakbary
Copy link
Member

syrusakbary commented Jan 22, 2021

Thanks for the ping! The new diagrams have white backgrounds (instead of transparent ones) so it's easier to read in Github with the dark theme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📚 documentation Do you like to read?
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants