Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(example) Add white background and reduce diagram sizes #2041

Merged
merged 5 commits into from
Jan 22, 2021
Merged

doc(example) Add white background and reduce diagram sizes #2041

merged 5 commits into from
Jan 22, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Jan 22, 2021 •
edited
Loading

Description

This PR adds a white background to the diagrams instead of having a transparent background. It fixes #2029.

The diagrams have also been compressed to reduce their file size (-32.3Kb, -45.8Kb, -19.5Kb saved).

Edit: This PR also fixes missing links and fix issues in the examples/README.md file.

Review

  • Add a short description of the the change to the CHANGELOG.md file

@Hywan Hywan added 🎉 enhancement New feature! 📚 documentation Do you like to read? labels Jan 22, 2021
@Hywan Hywan self-assigned this Jan 22, 2021
@Hywan Hywan requested a review from jubianchi as a code owner January 22, 2021 10:20
@Hywan
Copy link
Contributor Author

Hywan commented Jan 22, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 22, 2021

Build succeeded:

@bors bors bot merged commit 4378b22 into wasmerio:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubianchi jubianchi jubianchi approved these changes

Assignees

@Hywan Hywan

Labels
📚 documentation Do you like to read? 🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs issue: diagrams not readable in dark theme
2 participants
@Hywan @jubianchi