Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory load doesn't work as expected when using Windows #2549

Closed
syrusakbary opened this issue Sep 1, 2021 · 1 comment
Closed

Memory load doesn't work as expected when using Windows #2549

syrusakbary opened this issue Sep 1, 2021 · 1 comment
Assignees
@ptitSeb
Labels
bug Something isn't working 📦 lib-compiler-cranelift About wasmer-compiler-cranelift 🖼️ platform-windows This issue happens on Windows

Comments

@syrusakbary
Copy link
Member

syrusakbary commented Sep 1, 2021 •
edited by Hywan
Loading

Right now memory load spectests doesn't work as expected in Windows.

A successful fix should remove this line from ignores:

wasmer/tests/ignores.txt

Line 39 in 378550a

windows+cranelift spec::memory_grow

@syrusakbary syrusakbary added the bug Something isn't working label Sep 1, 2021
@Hywan Hywan added 📦 lib-compiler-cranelift About wasmer-compiler-cranelift 🖼️ platform-windows This issue happens on Windows labels Sep 2, 2021
@ptitSeb
Copy link
Contributor

ptitSeb commented Sep 3, 2021

Fixed with #2552

@ptitSeb ptitSeb closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptitSeb ptitSeb

Labels
bug Something isn't working 📦 lib-compiler-cranelift About wasmer-compiler-cranelift 🖼️ platform-windows This issue happens on Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@syrusakbary @Hywan @ptitSeb