fix(vm) Fix the memory_grow test on Windows (with a bigger page guard) #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Sep 3, 2021
|
bors r+ |
|
Canceled. |
|
bors r+ |
Hywan
added
bug
Hywan
reviewed
Sep 3, 2021
| @@ -52,13 +52,19 @@ impl BaseTunables { | |||
|
|
|||
| // Allocate a small guard to optimize common cases but without | |||
| // wasting too much memory. | |||
| // The Windows memory manager seems more laxed than the other ones | |||
| // And a guard of just 1 page may not be enough is some borderline cases | |||
| // So using 2 pages for guard on this plateform | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the memory_grow test under Windows.
The test was failling randomly, at the step with a dynamic memory block of size 0, when trying a read/write at pagesize offset, so just outside the pagegard in that case.
It seems windows memory manager may map a writable page just after the newly alocated block, so using a "2 pages" guard size on windows to avoid this issue.