Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/publish.py: replace toposort dependency with python std graphlib module #2965

Closed
epilys opened this issue Jun 21, 2022 · 0 comments · Fixed by #3126
Closed

scripts/publish.py: replace toposort dependency with python std graphlib module #2965

epilys opened this issue Jun 21, 2022 · 0 comments · Fixed by #3126
Labels
🎉 enhancement New feature! 🍋 Low-hanging Fruit priority-low Low priority issue 🔨 refactor Refactor work
Milestone
v3.0

Comments

@epilys
Copy link
Contributor

epilys commented Jun 21, 2022

Python standard library already includes a topological sorter: https://docs.python.org/3/library/graphlib.html

We don't need a third party dependency in scripts/publish.py.
@epilys epilys added 🎉 enhancement New feature! 🔨 refactor Refactor work priority-low Low priority issue labels Jun 21, 2022
@epilys epilys added this to the v3.0 milestone Jun 21, 2022
@epilys epilys mentioned this issue Aug 22, 2022
Merged
bors bot added a commit that referenced this issue Aug 22, 2022
@bors @epilys
Merge #3126
a766959 
3126: scripts/publish.py: replace toposort dependency with python std graphlib module r=epilys a=epilys

Python standard library already includes a topological sorter: https://docs.python.org/3/library/graphlib.html

We don't need a third party dependency in scripts/publish.py.

Closes #2965

Co-authored-by: Manos Pitsidianakis <manos@wasmer.io>
@bors bors bot closed this as completed in 54b0e5c Aug 22, 2022
ptitSeb pushed a commit that referenced this issue Oct 20, 2022
@epilys @ptitSeb
scripts/publish.py: replace toposort dependency with python std graph…
fcf169a 
…lib module

Python standard library already includes a topological sorter: https://docs.python.org/3/library/graphlib.html

We don't need a third party dependency in scripts/publish.py.

Closes #2965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature! 🍋 Low-hanging Fruit priority-low Low priority issue 🔨 refactor Refactor work
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

scripts/publish.py: replace toposort dependency with python std graphlib module wasmerio/wasmer
2 participants
@syrusakbary @epilys