New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back Function::new_with_env and Function::new_native_with_env. Make Function::new and Function::new_native not receive any env #3064

Closed

syrusakbary opened this issue Aug 2, 2022 · 0 comments · Fixed by #3072

Assignees

Milestone

Member

syrusakbary commented Aug 2, 2022 •

edited

Loading

Basically, we should rename:

Function::new to Function::new_with_env
Function::new_native to Function::new_typed_with_env

And then create:

Function::new (with no environment in the arg function, neither in the callback/closure provided)
Function::new_typed (with no environment in the arg function, neither in the callback/closure provided)

The text was updated successfully, but these errors were encountered:

syrusakbary added this to the v3.0 milestone

syrusakbary assigned silwol

silwol mentioned this issue

Add back Function::*_with_env(…) #3072

Merged

1 task

bors bot closed this as completed in

ced8378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment