Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back Function::*_with_env(…) #3072

Merged
merged 9 commits into from
Aug 5, 2022
Merged

Add back Function::*_with_env(…) #3072

merged 9 commits into from
Aug 5, 2022

Conversation

silwol
Copy link
Contributor

@silwol silwol commented Aug 4, 2022 •
edited
Loading

Closes: #3064

Description

Review

  • Add a short description of the change to the CHANGELOG.md file

@silwol silwol requested a review from syrusakbary as a code owner August 4, 2022 07:10
@silwol silwol marked this pull request as draft August 4, 2022 07:10
@silwol silwol force-pushed the silwol/add-back-functions-with-env branch 7 times, most recently from 70d279e to 50ba29d Compare August 4, 2022 18:36
@silwol silwol changed the title WIP: Re-add Function::*_with_env(…) Add back Function::*_with_env(…) Aug 5, 2022
@silwol silwol marked this pull request as ready for review August 5, 2022 08:14
@epilys epilys self-requested a review August 5, 2022 08:21
epilys
epilys reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@epilys epilys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ready for merging after rebasing and optionally implementing the minor suggested change for the trait.

lib/api/src/sys/externals/function.rs Show resolved Hide resolved
@silwol silwol force-pushed the silwol/add-back-functions-with-env branch from c7ce830 to 848cadb Compare August 5, 2022 10:41
@silwol silwol force-pushed the silwol/add-back-functions-with-env branch from 72fa8a1 to dcb3497 Compare August 5, 2022 12:27
syrusakbary
syrusakbary approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@silwol
Copy link
Contributor Author

silwol commented Aug 5, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 5, 2022

Build succeeded:

@bors bors bot merged commit ced8378 into master Aug 5, 2022
@bors bors bot deleted the silwol/add-back-functions-with-env branch August 5, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epilys epilys epilys left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@silwol @syrusakbary @epilys