Add fn for splitting borrow of memory & data in Ctx, use in WASI #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
added
📦 lib-deprecated
nlewycky
reviewed
Dec 16, 2019
lib/runtime-core/src/vm.rs
Outdated
| @@ -401,6 +401,21 @@ impl Ctx { | |||
| } | |||
| } | |||
|
|
|||
| /// Splits the borrow, getting both Memory and a mutable reference to | |||
There was a problem hiding this comment.
"Splits the borrow" sounds like a function that takes a borrow and splits it. Instead, this is a variation on memory that returns a Memory and a mutable reference to the Ctx.data.
Also, I'd replace "a hostcall" with simply "the host".
There was a problem hiding this comment.
It's required by the Rust borrow checker; it's a split borrow in that one borrow comes in and 2 come out that otherwise is not possible with safe Rust. There's a function for splitting borrows over slices I believe &mut [u8] -> (&mut [u8], &mut [u8]) which is where I got the terminology from
nlewycky
approved these changes
Dec 16, 2019
Co-Authored-By: nlewycky <nick@wasmer.io>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 17, 2019
1069: Add fn for splitting borrow of memory & data in Ctx, use in WASI r=MarkMcCaskey a=MarkMcCaskey Fixes a soundness issue / some undefined behavior # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <5770194+markmccaskey@users.noreply.github.com>
|
bors r- |
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 17, 2019
1069: Add fn for splitting borrow of memory & data in Ctx, use in WASI r=MarkMcCaskey a=MarkMcCaskey Fixes a soundness issue / some undefined behavior # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <5770194+markmccaskey@users.noreply.github.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a soundness issue / some undefined behavior
Review